More thorough error handling.

[gedcom-parse.git] / gom / place.c

diff --git a/gom/place.c b/gom/place.c
index a77ff91a88a48cdc9f6f63e6d91b0b9d654f0e10..bb6ead6586f43499bea300d1be4047778af01c9c 100644 (file)
--- a/gom/place.c
+++ b/gom/place.c
@@ -36,29 +36,42 @@
 Gedcom_ctxt sub_place_start(_ELT_PARAMS_)
 {
   Gom_ctxt ctxt = (Gom_ctxt)parent;
-  struct place *place = NULL;
+  Gom_ctxt result = NULL;
 
-  if (ctxt) {
-    place = (struct place *)malloc(sizeof(struct place));
-    memset (place, 0, sizeof(struct place));
-    place->value = strdup(GEDCOM_STRING(parsed_value));
-
-    switch (ctxt->ctxt_type) {
-      case ELT_SUB_FAM_EVT:
-      case ELT_SUB_FAM_EVT_EVEN:
-      case ELT_SUB_INDIV_ATTR:
-      case ELT_SUB_INDIV_RESI:
-      case ELT_SUB_INDIV_BIRT:
-      case ELT_SUB_INDIV_GEN:
-      case ELT_SUB_INDIV_ADOP:
-      case ELT_SUB_INDIV_EVEN:
-       event_add_place(ctxt, place); break;
-      default:
-       UNEXPECTED_CONTEXT(ctxt->ctxt_type);
+  if (! ctxt)
+    NO_CONTEXT;
+  else {
+    struct place *place = (struct place *)malloc(sizeof(struct place));
+    if (! place)
+      MEMORY_ERROR;
+    else {
+      memset (place, 0, sizeof(struct place));
+      place->value = strdup(GEDCOM_STRING(parsed_value));
+      
+      if (!place->value) {
+       MEMORY_ERROR;
+       free(place);
+      }
+      else {
+       switch (ctxt->ctxt_type) {
+         case ELT_SUB_FAM_EVT:
+         case ELT_SUB_FAM_EVT_EVEN:
+         case ELT_SUB_INDIV_ATTR:
+         case ELT_SUB_INDIV_RESI:
+         case ELT_SUB_INDIV_BIRT:
+         case ELT_SUB_INDIV_GEN:
+         case ELT_SUB_INDIV_ADOP:
+         case ELT_SUB_INDIV_EVEN:
+           event_add_place(ctxt, place); break;
+         default:
+           UNEXPECTED_CONTEXT(ctxt->ctxt_type);
+       }
+       result = MAKE_GOM_CTXT(elt, place, place);
+      }
     }
   }
 
-  return (Gedcom_ctxt) MAKE_GOM_CTXT(elt, place, place);
+  return (Gedcom_ctxt)result;
 }
 
 STRING_CB(place, sub_place_form_start, place_hierarchy)
@@ -66,19 +79,22 @@ STRING_CB(place, sub_place_form_start, place_hierarchy)
 void place_add_citation(Gom_ctxt ctxt, struct source_citation* cit)
 {
   struct place *place = SAFE_CTXT_CAST(place, ctxt);
-  LINK_CHAIN_ELT(source_citation, place->citation, cit)  
+  if (place)
+    LINK_CHAIN_ELT(source_citation, place->citation, cit);  
 }
 
 void place_add_note(Gom_ctxt ctxt, struct note_sub* note)
 {
   struct place *place = SAFE_CTXT_CAST(place, ctxt);
-  LINK_CHAIN_ELT(note_sub, place->note, note)  
+  if (place)
+    LINK_CHAIN_ELT(note_sub, place->note, note);  
 }
 
 void place_add_user_data(Gom_ctxt ctxt, struct user_data* data)
 {
   struct place *obj = SAFE_CTXT_CAST(place, ctxt);
-  LINK_CHAIN_ELT(user_data, obj->extra, data)
+  if (obj)
+    LINK_CHAIN_ELT(user_data, obj->extra, data);
 }
 
 void place_subscribe()
@@ -93,9 +109,9 @@ void place_cleanup(struct place* place)
   if (place) {
     SAFE_FREE(place->value);
     SAFE_FREE(place->place_hierarchy);
-    DESTROY_CHAIN_ELTS(source_citation, place->citation, citation_cleanup)  
-    DESTROY_CHAIN_ELTS(note_sub, place->note, note_sub_cleanup)
-    DESTROY_CHAIN_ELTS(user_data, place->extra, user_data_cleanup)
+    DESTROY_CHAIN_ELTS(source_citation, place->citation, citation_cleanup);  
+    DESTROY_CHAIN_ELTS(note_sub, place->note, note_sub_cleanup);
+    DESTROY_CHAIN_ELTS(user_data, place->extra, user_data_cleanup);
   }
   SAFE_FREE(place);
 }